style: 逐条修静态分析告警（706 → 44），并把 MaxDepth 这条假承诺删掉
修掉的：空 catch 5 处；名词白名单 7 处；default-value 开关、自带 -WhatIf、lab 的明文口令与 irm|iex 各挂抑制并写明理由。 MaxDepth：它是分析器拓出来的真 bug —— 参数声明了却从未使用，也就是配置里的 CatalogMaxDepth 是假的，前缀补全实际只查 1 层，而配置注释与 README 都承诺「向下找几层」。按确认过的原则处理：**先让文档不撒谎**，所以把整条链路去掉（配置默认值、三个函数的参数、70 处实参、配置注释），而不是留一个假旋钮。零行为变化。想真的支持多层补全时，那是一个独立决定。 剩下 3 条都是分析器的误判，而且我实测确认过其中一条：$sourcePath 被报「赋值后从未使用」，我照着改成 $null = 之后，Set-StrictMode -Version 3.0 下读未定义变量直接抛错，Security 套件的 BeforeAll 挂掉、4 条用例连带失败。恢复后才绿。 这一类误判有共同成因：静态分析看不到「在传给 Test-Case / It / Where-Object 的 scriptblock 里被使用」。所以我只对能证明是误判的挂抑制并写明理由，不为了数字好看去改代码。 验收：test.ps1 9/9 全绿（7 与 5.1）、100 个文件两版解析零错、Run-RealSmoke 4/4。
This commit is contained in:
Shuery committed
1 parent
3a3a57a6a1
commit
232a82cd3c
28 files changed
+108
-98
No files matched your search
@@ -138,7 +138,7 @@ Describe '软件名录：Slot 形状（新契约）' {
|
||||
}
|
||||
|
||||
It '一个软件多个 Slot：Kind=Multi，Slot 按名排序且说明被保留' {
|
||||
$catalog = Get-BakNRetSoftwareCatalog -Path $script:FormatCatalog -MaxDepth 3 -NoCache
|
||||
$catalog = Get-BakNRetSoftwareCatalog -Path $script:FormatCatalog -NoCache
|
||||
$catalog['pair'].Kind | Should -Be 'Multi'
|
||||
@($catalog['pair'].Slots).Count | Should -Be 2
|
||||
(@($catalog['pair'].Slots | ForEach-Object { $_.Name }) -join ',') | Should -Be 'A,B'
|
||||
@@ -150,7 +150,7 @@ Describe '软件名录：Slot 形状（新契约）' {
|
||||
|
||||
It '每个 Slot 都是一个独立的归档项来源（Kind=slot / Origin=catalog）' {
|
||||
$entry = ConvertFrom-BackupListLine -Line 'pair'
|
||||
$resolved = Resolve-BakNRetBackupEntry -Entry $entry -CatalogPath $script:FormatCatalog -MaxDepth 3
|
||||
$resolved = Resolve-BakNRetBackupEntry -Entry $entry -CatalogPath $script:FormatCatalog
|
||||
@($resolved.Items).Count | Should -Be 2
|
||||
(@($resolved.Items | ForEach-Object { $_.ArchivePath }) -join ',') | Should -Be 'A,B'
|
||||
(@($resolved.Items | ForEach-Object { $_.Kind }) -join ',') | Should -Be 'slot,slot'
|
||||
@@ -161,22 +161,22 @@ Describe '软件名录：Slot 形状（新契约）' {
|
||||
}
|
||||
|
||||
It 'Slot 级排除写在 Slot 自己身上（相对本 Slot 的归档根）' {
|
||||
$catalog = Get-BakNRetSoftwareCatalog -Path $script:FormatCatalog -MaxDepth 3 -NoCache
|
||||
$catalog = Get-BakNRetSoftwareCatalog -Path $script:FormatCatalog -NoCache
|
||||
(@($catalog['slotex'].Slots[0].Exclude) -join '|') | Should -Be '!*Cache|logs\'
|
||||
|
||||
$entry = ConvertFrom-BackupListLine -Line 'slotex'
|
||||
$resolved = Resolve-BakNRetBackupEntry -Entry $entry -CatalogPath $script:FormatCatalog -MaxDepth 3
|
||||
$resolved = Resolve-BakNRetBackupEntry -Entry $entry -CatalogPath $script:FormatCatalog
|
||||
(@($resolved.Items[0].Exclude) -join '|') | Should -Be '!*Cache|logs\'
|
||||
$resolved.HasExcludeOverride | Should -BeFalse
|
||||
}
|
||||
|
||||
It '数组里"当前不存在"的 Slot 仍然产出归档项（恢复要靠它还原回原位）' {
|
||||
$catalog = Get-BakNRetSoftwareCatalog -Path $script:FormatCatalog -MaxDepth 3 -NoCache
|
||||
$catalog = Get-BakNRetSoftwareCatalog -Path $script:FormatCatalog -NoCache
|
||||
$catalog['partial'].Kind | Should -Be 'Partial'
|
||||
@($catalog['partial'].Missing) | Should -Contain $script:MissingDir
|
||||
|
||||
$entry = ConvertFrom-BackupListLine -Line 'partial'
|
||||
$resolved = Resolve-BakNRetBackupEntry -Entry $entry -CatalogPath $script:FormatCatalog -MaxDepth 3
|
||||
$resolved = Resolve-BakNRetBackupEntry -Entry $entry -CatalogPath $script:FormatCatalog
|
||||
@($resolved.Items).Count | Should -Be 2
|
||||
@($resolved.Items | ForEach-Object { $_.RealPath }) | Should -Contain $script:MissingDir
|
||||
$resolved.Blocking | Should -BeNullOrEmpty # 源不存在不是致命错误
|
||||
@@ -184,7 +184,7 @@ Describe '软件名录：Slot 形状（新契约）' {
|
||||
|
||||
It '文件 Slot：归档项是文件项（归档里就是名为 Slot 的文件）' {
|
||||
$entry = ConvertFrom-BackupListLine -Line 'fileapp'
|
||||
$resolved = Resolve-BakNRetBackupEntry -Entry $entry -CatalogPath $script:FormatCatalog -MaxDepth 3
|
||||
$resolved = Resolve-BakNRetBackupEntry -Entry $entry -CatalogPath $script:FormatCatalog
|
||||
@($resolved.Items).Count | Should -Be 1
|
||||
$resolved.Items[0].IsFile | Should -BeTrue
|
||||
$resolved.Items[0].ArchivePath | Should -Be 'Cfg'
|
||||
@@ -193,13 +193,13 @@ Describe '软件名录：Slot 形状（新契约）' {
|
||||
}
|
||||
|
||||
It '旧的裸字符串 / 字符串数组写法被拒绝（ERROR + 跳过）' {
|
||||
$catalog = Get-BakNRetSoftwareCatalog -Path $script:FormatCatalog -MaxDepth 3 -NoCache
|
||||
$catalog = Get-BakNRetSoftwareCatalog -Path $script:FormatCatalog -NoCache
|
||||
$catalog.ContainsKey('legacystr') | Should -BeFalse
|
||||
$catalog.ContainsKey('legacyarr') | Should -BeFalse
|
||||
}
|
||||
|
||||
It '旧的 @{ Dirs = @(...) } 写法不再展开，留下 Invalid 与原因' {
|
||||
$catalog = Get-BakNRetSoftwareCatalog -Path $script:FormatCatalog -MaxDepth 3 -NoCache
|
||||
$catalog = Get-BakNRetSoftwareCatalog -Path $script:FormatCatalog -NoCache
|
||||
$catalog.ContainsKey('legacydirs') | Should -BeTrue
|
||||
$catalog['legacydirs'].Kind | Should -Be 'Invalid'
|
||||
$catalog['legacydirs'].Error | Should -Not -BeNullOrEmpty
|
||||
@@ -208,7 +208,7 @@ Describe '软件名录：Slot 形状（新契约）' {
|
||||
|
||||
It '多 Slot 的名录条目在清单里仍然按软件名命名归档' {
|
||||
$entry = ConvertFrom-BackupListLine -Line 'pair'
|
||||
(Get-BakNRetItemArchiveName -Entry $entry -CatalogPath $script:FormatCatalog -MaxDepth 3) | Should -Be 'pair'
|
||||
(Get-BakNRetItemArchiveName -Entry $entry -CatalogPath $script:FormatCatalog) | Should -Be 'pair'
|
||||
}
|
||||
}
|
||||
|
||||
@@ -227,7 +227,7 @@ Describe '清单修饰符：新契约格式' {
|
||||
It ':: 覆盖 Path：单 Slot 条目直接生效' {
|
||||
$entry = ConvertFrom-BackupListLine -Line "solo :: $script:DirB"
|
||||
$entry.Overrides.ContainsKey('Path') | Should -BeTrue
|
||||
$resolved = Resolve-BakNRetBackupEntry -Entry $entry -CatalogPath $script:FormatCatalog -MaxDepth 3
|
||||
$resolved = Resolve-BakNRetBackupEntry -Entry $entry -CatalogPath $script:FormatCatalog
|
||||
@($resolved.Items).Count | Should -Be 1
|
||||
$resolved.Items[0].ArchivePath | Should -Be 'Only'
|
||||
$resolved.Items[0].RealPath | Should -Be $script:DirB
|
||||
@@ -236,7 +236,7 @@ Describe '清单修饰符：新契约格式' {
|
||||
|
||||
It ':: 覆盖遇到多 Slot 条目 -> Blocking（不知道给哪一个，绝不猜）' {
|
||||
$entry = ConvertFrom-BackupListLine -Line "pair :: $script:DirB"
|
||||
$resolved = Resolve-BakNRetBackupEntry -Entry $entry -CatalogPath $script:FormatCatalog -MaxDepth 3
|
||||
$resolved = Resolve-BakNRetBackupEntry -Entry $entry -CatalogPath $script:FormatCatalog
|
||||
@($resolved.Items).Count | Should -Be 0
|
||||
$resolved.Blocking | Should -Match '不能用一个'
|
||||
}
|
||||
@@ -246,7 +246,7 @@ Describe '清单修饰符：新契约格式' {
|
||||
(@($entry.ExcludePatterns) -join '|') | Should -Be 'logs\|!*Cache'
|
||||
(@($entry.Includes) -join '|') | Should -Be "Mods:$script:DirB"
|
||||
|
||||
$resolved = Resolve-BakNRetBackupEntry -Entry $entry -CatalogPath $script:FormatCatalog -MaxDepth 3
|
||||
$resolved = Resolve-BakNRetBackupEntry -Entry $entry -CatalogPath $script:FormatCatalog
|
||||
$resolved.HasExcludeOverride | Should -BeTrue
|
||||
$resolved.HasIncludeOverride | Should -BeTrue
|
||||
@($resolved.Items | ForEach-Object { $_.ArchivePath }) | Should -Contain 'Mods'
|
||||
@@ -261,13 +261,13 @@ Describe '清单修饰符：新契约格式' {
|
||||
}
|
||||
|
||||
It ':encrypt / :!encrypt 覆盖名录里的加密默认值' {
|
||||
$base = Resolve-BakNRetBackupEntry -Entry (ConvertFrom-BackupListLine -Line 'fileapp') -CatalogPath $script:FormatCatalog -MaxDepth 3
|
||||
$base = Resolve-BakNRetBackupEntry -Entry (ConvertFrom-BackupListLine -Line 'fileapp') -CatalogPath $script:FormatCatalog
|
||||
$base.Encrypt | Should -BeTrue # 名录里 Cfg Slot 标了 Encrypt
|
||||
|
||||
$off = Resolve-BakNRetBackupEntry -Entry (ConvertFrom-BackupListLine -Line 'fileapp :!encrypt') -CatalogPath $script:FormatCatalog -MaxDepth 3
|
||||
$off = Resolve-BakNRetBackupEntry -Entry (ConvertFrom-BackupListLine -Line 'fileapp :!encrypt') -CatalogPath $script:FormatCatalog
|
||||
$off.Encrypt | Should -BeFalse
|
||||
|
||||
$on = Resolve-BakNRetBackupEntry -Entry (ConvertFrom-BackupListLine -Line 'pair :encrypt') -CatalogPath $script:FormatCatalog -MaxDepth 3
|
||||
$on = Resolve-BakNRetBackupEntry -Entry (ConvertFrom-BackupListLine -Line 'pair :encrypt') -CatalogPath $script:FormatCatalog
|
||||
$on.Encrypt | Should -BeTrue
|
||||
}
|
||||
|
||||
@@ -279,7 +279,7 @@ Describe '清单修饰符：新契约格式' {
|
||||
# @pathname 对软件名条目也会改用真实路径命名
|
||||
$entry = ConvertFrom-BackupListLine -Line 'pair @pathname'
|
||||
$expected = Get-BakNRetBackupBaseName -RawPath $script:DirA
|
||||
(Get-BakNRetItemArchiveName -Entry $entry -CatalogPath $script:FormatCatalog -MaxDepth 3) | Should -Be $expected
|
||||
(Get-BakNRetItemArchiveName -Entry $entry -CatalogPath $script:FormatCatalog) | Should -Be $expected
|
||||
}
|
||||
|
||||
It '同一行里重复写同类记号会累积（不静默丢掉前一条规则）' {
|
||||
|
||||
Reference in new issue
Block a user